resolved comments

apache · Feb 18, 2024 · 53a3ff4 · 53a3ff4
1 parent ad1f59f
commit 53a3ff4
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 3 deletions.
diff --git a/lib/ClientConnection.cc b/lib/ClientConnection.cc
@@ -1794,6 +1794,7 @@ void ClientConnection::handleTopicMigrated(const proto::CommandTopicMigrated& co
         return;
     }
 
+    Lock lock(mutex_);
     if (commandTopicMigrated.resource_type() == proto::CommandTopicMigrated_ResourceType_Producer) {
         auto it = producers_.find(resourceId);
         if (it != producers_.end()) {

diff --git a/lib/ProducerImpl.cc b/lib/ProducerImpl.cc
@@ -144,7 +144,7 @@ Future<Result, bool> ProducerImpl::connectionOpened(const ClientConnectionPtr& c
         return promise.getFuture();
     }
 
-    LOG_DEBUG("Creating producer" << topic() << "producerName: " << producerName_ << " on "
+    LOG_DEBUG("Creating producer for topic:" << topic() << ", producerName:" << producerName_ << " on "
                                   << cnx->cnxString());
     ClientImplPtr client = client_.lock();
     cnx->registerProducer(producerId_, shared_from_this());

diff --git a/proto/PulsarApi.proto b/proto/PulsarApi.proto
@@ -622,7 +622,7 @@ message CommandReachedEndOfTopic {
 }
 
 message CommandTopicMigrated {
-	enum ResourceType {
+    enum ResourceType {
         Producer = 0;
         Consumer = 1;
     }

diff --git a/tests/extensibleLM/ExtensibleLoadManagerTest.cc b/tests/extensibleLM/ExtensibleLoadManagerTest.cc
@@ -70,7 +70,9 @@ TEST(ExtensibleLoadManagerTest, testPubSubWhileUnloading) {
         return res == 204 || res == 409;
     }));
 
-    Client client{"pulsar://localhost:6650"};
+    ClientConfiguration conf;
+    conf.setIOThreads(8);
+    Client client{"pulsar://localhost:6650", conf};
     Producer producer;
     ProducerConfiguration producerConfiguration;
     Result producerResult = client.createProducer(topicName, producerConfiguration, producer);