fix(plc4j/drivers/s7): Delete 2 duplicate classes #1878
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…located in org.apache.plc4x.java.s7.readwrite.protocol (cherry picked from commit 5b1cc09)
|
@glcj why are those files in both locations? Fix looks fine, can't judge where they are supposed to be... |
sruehl
approved these changes
Nov 8, 2024
|
Hi, S7Mux is actually an interface. Normally it should be in a ".api" package. Its purpose is to be able to implement with a second instance of "S7MuxImpl", the case of four communication channels that Siemens achieves with the RECONNECT application [1]. A bit difficult to achieve, but oh well, that was the idea. I don't see any problem with the modification. |
|
K, ty for the PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Delete 2 duplicate classes, the used ones are located in org.apache.plc4x.java.s7.readwrite.protocol.