OMID-284 Use protobuf 4 in Omid #170
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NihalJain
reviewed
Oct 15, 2024
| <protobuf-java.version>2.5.0</protobuf-java.version> | ||
| <protoc.version>2.5.0</protoc.version> | ||
| <protobuf-java.version>4.28.2</protobuf-java.version> | ||
| <protoc.version>4.28.2</protoc.version> |
There was a problem hiding this comment.
we should remove profile for linux-aarch64
NihalJain
reviewed
Oct 15, 2024
| @@ -16,51 +16,51 @@ | |||
| // limitations under the License. | |||
| // | |||
|
|
|||
| syntax = "proto3"; | |||
There was a problem hiding this comment.
any reason for building with proto3? hbase still uses proto2 even though builds with proto 4.8.2?
|
Also how do we deal with hadoop related tests if we donot use a shaded proto version here? Should we have a shaded protobuf similar to hbase? |
Or may be just use hbase-thirdparty protobuf as suggested in https://issues.apache.org/jira/browse/OMID-276 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.