use sbt-pekko-build #826
Merged
use sbt-pekko-build #826
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@pjfanning I just pushed 2 commits on this branch. The first one just updates from latest |
pjfanning
force-pushed
the
sbt-pekko-build
branch
from
ea29de1 to
033a935
Compare
pjfanning
requested review from
mdedetrich,
He-Pin,
nvollmar and
samueleresca
|
Let me check the flags are smart with and without this change |
mdedetrich
approved these changes
Jan 15, 2024
He-Pin
reviewed
Jan 15, 2024
| @@ -26,6 +26,11 @@ commands := commands.value.filterNot { command => | |||
|
|
|||
| ThisBuild / reproducibleBuildsCheckResolver := Resolver.ApacheMavenStagingRepo | |||
|
|
|||
| ThisBuild / pekkoCoreProject := true | |||
There was a problem hiding this comment.
add a comment about this pekkoCoreProject?
There was a problem hiding this comment.
I mean it's kind of implied, this repo is the core pekko project?
|
@pjfanning Do you want to cherry pick or should I? |
You can do this if you like |
mdedetrich
pushed a commit
to mdedetrich/pekko
that referenced
this pull request
Jan 15, 2024
* try sbt-pekko-build * Use latest sbt-pekko-build 0.3.0 * remove temp resolver --------- Co-authored-by: Matthew de Detrich <[email protected]> (cherry picked from commit dc03474)
mdedetrich
pushed a commit
that referenced
this pull request
Jan 15, 2024
* try sbt-pekko-build * Use latest sbt-pekko-build 0.3.0 * remove temp resolver --------- Co-authored-by: Matthew de Detrich <[email protected]> (cherry picked from commit dc03474)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
allow us to share some build code across projects