Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add Akka path parsing tests #819

Merged
merged 1 commit into from
Nov 28, 2023
Merged

add Akka path parsing tests #819

merged 1 commit into from
Nov 28, 2023

Conversation

pjfanning
Copy link
Contributor

relates to #765

These tests prove that Pekko doesn't actively check the URI scheme - at least at the initial URI parsing point.

nvollmar
nvollmar approved these changes Nov 28, 2023
View reviewed changes
Copy link
Contributor

@nvollmar nvollmar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@pjfanning pjfanning merged commit 8fefca1 into apache:main Nov 28, 2023
18 checks passed
@pjfanning pjfanning deleted the akka-path-tests branch November 28, 2023 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nvollmar nvollmar nvollmar approved these changes

@mdedetrich mdedetrich Awaiting requested review from mdedetrich

@samueleresca samueleresca Awaiting requested review from samueleresca

@jxnu-liguobin jxnu-liguobin Awaiting requested review from jxnu-liguobin

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pjfanning @nvollmar