Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: javadoc link and typo fixes #675

Merged
merged 2 commits into from
Sep 24, 2023

Conversation

Roiocam
Copy link
Member

@Roiocam Roiocam commented Sep 23, 2023

As described in the title, resolve some javadoc linking issues that cannot be properly addressed within the IDE.

Copy link
Contributor

@mdedetrich mdedetrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mdedetrich mdedetrich merged commit 07c5935 into apache:main Sep 24, 2023
17 checks passed
@Roiocam Roiocam deleted the javadoc-fix-roiocam branch September 24, 2023 14:56
@@ -185,5 +185,5 @@ trait PoolRouter[T] extends Behavior[T] {
/**
* Any message that the predicate returns true for will be broadcast to all routees.
*/
def withBroadcastPredicate(pred: T => Boolean): PoolRouter[T]
def withBroadcastPredicate(predicate: T => Boolean): PoolRouter[T]
Copy link
Member Author

@Roiocam Roiocam Sep 24, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Per @He-Pin , this change may not source safe, because scala Named Arguments

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants