=remote Make ues of Netty's default resolver. #651
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
He-Pin
force-pushed
the
AddressResolver
branch
3 times, most recently
from
c380a4e to
6652cc3
Compare
remote/src/main/scala/org/apache/pekko/remote/transport/netty/NettyTransport.scala
Outdated
Show resolved
Hide resolved
He-Pin
force-pushed
the
AddressResolver
branch
from
6652cc3 to
26caaa9
Compare
He-Pin
force-pushed
the
AddressResolver
branch
2 times, most recently
from
ebf6cc5 to
51361bc
Compare
Merged
He-Pin
force-pushed
the
AddressResolver
branch
2 times, most recently
from
35acaa8 to
5524b4b
Compare
|
@pjfanning @mdedetrich This is ready |
pjfanning
reviewed
Sep 18, 2023
remote/src/main/scala/org/apache/pekko/remote/transport/netty/NettyTransport.scala
Show resolved
Hide resolved
pjfanning
requested changes
Sep 18, 2023
pjfanning
reviewed
Sep 18, 2023
remote/src/main/scala/org/apache/pekko/remote/transport/netty/NettyTransport.scala
Outdated
Show resolved
Hide resolved
pjfanning
reviewed
Sep 18, 2023
| override def associate(remoteAddress: Address): Future[AssociationHandle] = { | ||
| if (!serverChannel.isActive) Future.failed(new NettyTransportException("Transport is not bound")) | ||
| else { | ||
| val bootstrap: ClientBootstrap = outboundBootstrap(remoteAddress) | ||
|
|
||
| (for { | ||
| socketAddress <- addressToSocketAddress(remoteAddress) | ||
| readyChannel <- NettyFutureBridge(bootstrap.connect(socketAddress)).map { channel => | ||
| (host, port) <- Future.fromTry(Try(extractHostAndPort(remoteAddress))) |
There was a problem hiding this comment.
this seems bad to wrap the extractHostAndPort in a Try and a Future. Why do this call before the for comprehension so you won't need to wrap the result.
There was a problem hiding this comment.
Because it throws, the current style will keep the exception been handled by the recover block.
He-Pin
force-pushed
the
AddressResolver
branch
from
5524b4b to
44d0f78
Compare
He-Pin
force-pushed
the
AddressResolver
branch
from
44d0f78 to
75e18be
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
In Netty 4 , which ships with default resolver, so I think the blocking code can be removed.
refs: akka/akka#12960
Netty's Default resolver is the InetSocketResolver too.