Migrate the classic transport to Netty 4 without CVEs #643
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
He-Pin
force-pushed
the
classicNetty4
branch
3 times, most recently
from
781f07d to
2517d0a
Compare
He-Pin
force-pushed
the
classicNetty4
branch
from
a806ca0 to
7698c19
Compare
He-Pin
force-pushed
the
classicNetty4
branch
from
7698c19 to
adc452a
Compare
mdedetrich
approved these changes
Sep 11, 2023
There was a problem hiding this comment.
I know we wanted to do a community review on this but since its a draft it cannot be merged anyways.
Also considering the comparitive triviality of this PR, I don't think there is any real harm in merging this. Nothing is stopping us from dropping classical remoting later if we decide to do so, but the fact still remains that either we ship with CVE's or break SemVer
He-Pin
force-pushed
the
classicNetty4
branch
from
1273159 to
3f1d651
Compare
|
I think I had ran 10+ tests and all passed. |
He-Pin
force-pushed
the
classicNetty4
branch
from
6c53ea3 to
afb899d
Compare
He-Pin
force-pushed
the
classicNetty4
branch
from
afb899d to
a92c2d1
Compare
He-Pin
commented
Sep 12, 2023
remote/src/main/scala/org/apache/pekko/remote/transport/netty/TcpSupport.scala
Show resolved
Hide resolved
pjfanning
reviewed
Sep 13, 2023
remote/src/main/scala/org/apache/pekko/remote/transport/netty/NettyHelpers.scala
Outdated
Show resolved
Hide resolved
He-Pin
force-pushed
the
classicNetty4
branch
from
6a6639f to
7378394
Compare
He-Pin
force-pushed
the
classicNetty4
branch
from
7378394 to
9236d75
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Better performance and no CVES.
Open for votes.
refs: https://issues.apache.org/jira/browse/FLINK-29065
was: #540
This change simpler vs the previous one.
refs: apache/flink#22271
refs: apache/flink#22996
NOTE:
Need to make sure
MultiJvm/testpass.And Netty 4's migration guide: https://github.com/netty/netty/wiki/New-and-noteworthy-in-4.0
@zentol cc