=str Avoid sub materialization in lazySingle. #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pjfanning
reviewed
Nov 16, 2022
akka-stream/src/main/scala/akka/stream/impl/fusing/LazySingleSource.scala
Outdated
Show resolved
Hide resolved
pjfanning
approved these changes
Nov 16, 2022
|
@He-Pin You need to rebase this |
|
@He-Pin Do you want to look into this now that we are on 1.1.x series (i.e. rebase on current main)? Also if possible and easy to do so would it be possible to add a benchmark in https://github.com/apache/incubator-pekko/tree/b0fdac259bd57fdd481483f3fe9a7aec6e1ff38a/bench-jmh/src/main/scala/org/apache/pekko/stream ? While I am sure that you version has better performance, the adding of the benchmark is to prevent any potential future performance regressions. |
mdedetrich
reviewed
Jul 31, 2023
stream/src/main/scala/org/apache/pekko/stream/impl/fusing/LazySingleSource.scala
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs: #46
There is already a PR in akka , which using
single(()).map(_ => create())which is simpler, this code itself is easy to understand too, or should I go withsingle(create).map(_())?Will have to wait: #38