Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated references from akka to pekko #28 #36

Merged
merged 6 commits into from
Nov 15, 2022

Conversation

samikrc
Copy link
Contributor

@samikrc samikrc commented Nov 8, 2022

Updated three markdown files:

  • CONTRIBUTING.md
  • README.md
  • RELEASING.md

CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Show resolved Hide resolved
RELEASING.md Outdated Show resolved Hide resolved
@pjfanning
Copy link
Contributor

There was an existing PR that was approved and is now merged - #33.

It is worth checking to see what other issues and PRs are open before proceeding with new PRs.

Could you rebase your changes and look at PR comments?

@pjfanning
Copy link
Contributor

@samikrc I hope you don't mind but I resolved the merge conflicts myself. Would you be still able to make the rest of the requested changes?

@samikrc
Copy link
Contributor Author

samikrc commented Nov 8, 2022

Hi @pjfanning : thanks for the review. I have incorporated all the comments. Please review.

@samikrc samikrc requested a review from pjfanning November 8, 2022 17:07
CONTRIBUTING.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
@samikrc samikrc requested a review from pjfanning November 9, 2022 16:46
CONTRIBUTING.md Outdated Show resolved Hide resolved
@samikrc samikrc requested review from gmethvin and removed request for pjfanning November 10, 2022 17:28
CONTRIBUTING.md Show resolved Hide resolved
CONTRIBUTING.md Show resolved Hide resolved
CONTRIBUTING.md Show resolved Hide resolved
CONTRIBUTING.md Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Show resolved Hide resolved
CONTRIBUTING.md Show resolved Hide resolved
CONTRIBUTING.md Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
RELEASING.md Show resolved Hide resolved
@samikrc
Copy link
Contributor Author

samikrc commented Nov 14, 2022

Hello @pjfanning @Claudenw : I have not seen any new comment in last couple of days and the PR is ready. Can this be merged? Thanks!
@Claudenw : Can #28 be assigned to me?

@He-Pin He-Pin added this to the 1.0.0 milestone Nov 15, 2022
@pjfanning pjfanning merged commit 9edbc60 into apache:main Nov 15, 2022
@pjfanning
Copy link
Contributor

thanks @samikrc - I'll merge as is - it is good to lower the Akka specific references in the docs - any remaining issues can be resolved in new PRs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants