perf: optmize NettyChannelHandlerAdapter with explict extends. #1667
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
He-Pin
commented
Jan 3, 2025
| onMessage(ctx, buf) | ||
| } catch { | ||
| case ex: Throwable => transformException(ctx, ex) | ||
| } finally buf.release() // ByteBuf must be released explicitly |
There was a problem hiding this comment.
it was released by the finally block in SimpleChannelInboundHandler
raboof
approved these changes
Jan 3, 2025
There was a problem hiding this comment.
the upstream code is at https://github.com/netty/netty/blob/4.1/transport/src/main/java/io/netty/channel/SimpleChannelInboundHandler.java
unrolling the generic code that checks for types dynamically makes some sense
|
I ran the cluster test locally and it passed too, we are using this kind of trick at work. |
|
@raboof @pjfanning Do you think we should backport this? as Flink will use this pekko too. |
|
I don't want to pre-empt anything. If Flink team want to test the 1.2.0 snapshot and find that works better for them - we could then consider backporting this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Performance, it was extended to the
SimpleChannelInboundHandlerwhich will check if the type is aByteBuf, now, we just test it explicitly.Modification:
Make it extends the
ChannelInboundHandlerAdapterandreleaseexplicitly , which was released by theSimpleChannelInboundHandlerResult:
Simple code and performance a little better.