Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Enable netty leak detector in CI #1639

Merged
merged 1 commit into from
Dec 28, 2024

Conversation

He-Pin
Copy link
Member

@He-Pin He-Pin commented Dec 28, 2024

Motivation:
It needs to be enabled in .jvmopts-ci too.
refs: #1634

otherwise, it's just :

          io.netty.util.ResourceLeakDetector -- -Dio.netty.leakDetection.level: simple

Modification:
Add -Dio.netty.leakDetection.level=PARANOID (max level) to .jvmopts-ci

Result:
Can detect leak in CI

@He-Pin He-Pin requested a review from pjfanning December 28, 2024 17:54
@He-Pin He-Pin added the build sbt or build of the project label Dec 28, 2024
@He-Pin He-Pin added this to the 1.2.0 milestone Dec 28, 2024
.jvmopts-ci Outdated Show resolved Hide resolved
Copy link
Contributor

@pjfanning pjfanning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@He-Pin He-Pin merged commit fc09ac6 into apache:main Dec 28, 2024
8 checks passed
@He-Pin He-Pin deleted the enable-leak-detector-ci branch December 28, 2024 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build sbt or build of the project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants