-
Notifications
You must be signed in to change notification settings - Fork 151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add Sink.none operator #1614
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it is not usually acceptable to add new features in a patch (in semver)
If there will be a 1.2.0 release, I suggest we delete some deprecated code and maybe drop Java 8 and Scala 2.12 too. |
But if we only delivery features in minor release , that will slow us down |
Seems like a nice utility. I agree we shouldn't slow ourselves down. In this case following semver strictly just means the 'since' tag should be 1.2.0 and the next release will be 1.2.0, right? That seems fine to me? |
Having a 1.2.0 release does come with an overhead of adding extra testing in our other repos to test with 1.0, 1.1, 1.2 jars but it is achievable. |
Co-authored-by: Arnout Engelen <[email protected]>
Maybe we can relax that, which means only removing things in the minor version, this way, we can move faster, otherwise , any contributor will wait a little longer to have their contributions released. |
Motivation:
refs: #1613
refs https://github.com/Kotlin/kotlinx.coroutines/releases/tag/1.10.0 too.
Result:
Sink#none
operator