Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add Sink.none operator #1614

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

feat: Add Sink.none operator #1614

wants to merge 2 commits into from

Conversation

He-Pin
Copy link
Member

@He-Pin He-Pin commented Dec 21, 2024

Motivation:

refs: #1613
refs https://github.com/Kotlin/kotlinx.coroutines/releases/tag/1.10.0 too.

Result:

  1. add Sink#none operator
  2. The doc renders OK
image

@He-Pin He-Pin added the t:stream Pekko Streams label Dec 21, 2024
@He-Pin He-Pin added this to the 1.1.3 milestone Dec 21, 2024
Copy link
Contributor

@pjfanning pjfanning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it is not usually acceptable to add new features in a patch (in semver)

@He-Pin He-Pin modified the milestones: 1.1.3, 1.2.0 Dec 21, 2024
@He-Pin
Copy link
Member Author

He-Pin commented Dec 21, 2024

If there will be a 1.2.0 release, I suggest we delete some deprecated code and maybe drop Java 8 and Scala 2.12 too.

@He-Pin
Copy link
Member Author

He-Pin commented Dec 21, 2024

But if we only delivery features in minor release , that will slow us down
I agree that we should only delete things in minor release.

@He-Pin He-Pin modified the milestones: 1.2.0, 1.1.3 Dec 21, 2024
@raboof
Copy link
Member

raboof commented Dec 22, 2024

Seems like a nice utility.

I agree we shouldn't slow ourselves down.

In this case following semver strictly just means the 'since' tag should be 1.2.0 and the next release will be 1.2.0, right? That seems fine to me?

@pjfanning
Copy link
Contributor

Seems like a nice utility.

I agree we shouldn't slow ourselves down.

In this case following semver strictly just means the 'since' tag should be 1.2.0 and the next release will be 1.2.0, right? That seems fine to me?

Having a 1.2.0 release does come with an overhead of adding extra testing in our other repos to test with 1.0, 1.1, 1.2 jars but it is achievable.

@He-Pin
Copy link
Member Author

He-Pin commented Dec 22, 2024

Maybe we can relax that, which means only removing things in the minor version, this way, we can move faster, otherwise , any contributor will wait a little longer to have their contributions released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
t:stream Pekko Streams
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants