-
Notifications
You must be signed in to change notification settings - Fork 151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
reimplement fix for akka/pekko cluster #1594
base: main
Are you sure you want to change the base?
Conversation
My changes have fixed most tests but the new ones in this PR are still broken. It looks like we need more changes in org.apache.pekko.remote.Remoting$.localAddressForRemote.
|
@raboof @He-Pin @sadekmunawar I think I have all the tests passing now. I will check again later. If these changes are approved, I can remove the temp change to run the nightly tests during CI build of this PR. #1610 raised for a flaky test |
I have not look into the details, but will it replay the akka node with akka protocol ?otherwise, it will not work. can a akka node sending ping-pong after joined? And there are akka.tcp and akka protocols, which should be tested too. |
Run I the tests locally they pass but the nightly tests were failing until I removed this change.
see #1590