Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reimplement fix for akka/pekko cluster #1594

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

pjfanning
Copy link
Contributor

@pjfanning pjfanning commented Dec 16, 2024

Run I the tests locally they pass but the nightly tests were failing until I removed this change.

see #1590

sbt \
            -Dpekko.cluster.assert=on \
            -Dpekko.log.timestamps=true \
            -Dpekko.test.timefactor=2 \
            -Dpekko.actor.testkit.typed.timefactor=2 \
            -Dpekko.test.tags.exclude=gh-exclude,timing \
            -Dpekko.test.multi-in-test=false \
"cluster/testOnly *JoinConfigCompatCheckerRollingUpdateSpec"

@pjfanning pjfanning marked this pull request as draft December 16, 2024 20:47
@pjfanning
Copy link
Contributor Author

@raboof @kerr @sadekmunawar

My changes have fixed most tests but the new ones in this PR are still broken. It looks like we need more changes in org.apache.pekko.remote.Remoting$.localAddressForRemote.

Error:  [12/16/2024 22:04:04.724] [MixedProtocolClusterSpec-pekko.actor.internal-dispatcher-4] [org.apache.pekko.cluster.ClusterActorRefProvider] No root guardian at [pekko.tcp://[email protected]:40819]
org.apache.pekko.remote.RemoteTransportException: No transport is loaded for protocol: [pekko.tcp], available protocols: [akka.tcp]
	at org.apache.pekko.remote.Remoting$.localAddressForRemote(Remoting.scala:125)
	at org.apache.pekko.remote.Remoting.localAddressForRemote(Remoting.scala:168)
	at org.apache.pekko.remote.RemoteActorRefProvider.rootGuardianAt(RemoteActorRefProvider.scala:488)

@pjfanning pjfanning marked this pull request as ready for review December 17, 2024 12:15
@pjfanning pjfanning marked this pull request as draft December 17, 2024 12:39
@pjfanning
Copy link
Contributor Author

pjfanning commented Dec 17, 2024

@raboof @He-Pin @sadekmunawar I think I have all the tests passing now. I will check again later. If these changes are approved, I can remove the temp change to run the nightly tests during CI build of this PR.

#1610 raised for a flaky test

@He-Pin
Copy link
Member

He-Pin commented Dec 17, 2024

I have not look into the details, but will it replay the akka node with akka protocol ?otherwise, it will not work. can a akka node sending ping-pong after joined?

And there are akka.tcp and akka protocols, which should be tested too.

@pjfanning
Copy link
Contributor Author

@He-Pin this PR is based on #1567 but makes extra changes because the nightly tests failed with the 1567 changes. Specifically, the some nightly tests use pekko.tcp/akka.tcp transports. 1567 did not properly support the .tcp transports. These changes fix that.

@pjfanning pjfanning marked this pull request as ready for review December 21, 2024 15:43
@pjfanning pjfanning changed the title try to find issue with akka/pekko cluster change reimplement fix for akka/pekko cluster Dec 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants