Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: resolves and addition tests for child preStart supervise (#1385) #1396

Merged
merged 1 commit into from
Jul 16, 2024

Conversation

Roiocam
Copy link
Member

@Roiocam Roiocam commented Jul 16, 2024

backport to 1.0.x - #1385

…#1385)

* chore: add unit test for child actor initial exception supervise

* make assertion correct

* trying to fix assertion failed

* distinguish between fatal and normal fault

* fix unit tests

* trying to fix

* fix NPE

* revert isFailed condition

* revert isFailed place

* additional tests
Copy link
Contributor

@pjfanning pjfanning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Roiocam Roiocam merged commit e5cdce1 into apache:1.0.x Jul 16, 2024
18 checks passed
@Roiocam Roiocam deleted the backport-1385 branch July 16, 2024 07:49
@pjfanning pjfanning modified the milestones: 1.0.3, 1.0.4 Jul 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants