Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid unnecessary shard updates while shutting down (#1342) #1353

Merged
merged 1 commit into from
Jun 4, 2024
Merged

Avoid unnecessary shard updates while shutting down (#1342) #1353

merged 1 commit into from
Jun 4, 2024

Conversation

nvollmar
Copy link
Contributor

@nvollmar nvollmar commented Jun 4, 2024 •
edited by pjfanning
Loading

  • Avoid unnecessary shard updates while shutting down
  • Avoid re-creating the same message for each shard

cherry pick 92b38e7

@nvollmar
Avoid unnecessary shard updates while shutting down (#1342)
163f6e8 
* Avoid unnecessary shard updates while shutting down

* Avoid re-creating the same message for each shard
@nvollmar nvollmar requested a review from pjfanning June 4, 2024 05:44
@nvollmar nvollmar added this to the 1.0.3 milestone Jun 4, 2024
pjfanning
pjfanning approved these changes Jun 4, 2024
View reviewed changes
Copy link
Contributor

@pjfanning pjfanning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@nvollmar nvollmar merged commit 4f77c81 into 1.0.x Jun 4, 2024
18 checks passed
@nvollmar nvollmar deleted the 1342-backport branch June 4, 2024 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pjfanning pjfanning pjfanning approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.0.3
Development

Successfully merging this pull request may close these issues.
2 participants
@nvollmar @pjfanning