Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use more realistic version numbers in ManifestInfoSpec #1323

Merged
merged 1 commit into from
May 13, 2024

Conversation

Philippus
Copy link
Contributor

@Philippus Philippus commented May 13, 2024

Applying this PR will use more realistic version numbers in the ManifestInfoSpec. Right now they are clearly based on akka versions, which could potentially be confusing.

Copy link
Contributor

@laglangyue laglangyue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Member

@He-Pin He-Pin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks

Copy link
Member

@Roiocam Roiocam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks.

@raboof raboof merged commit 7ce4c0c into apache:main May 13, 2024
18 checks passed
@Philippus Philippus deleted the make-spec-more-realistic branch May 13, 2024 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants