Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update sbt to 1.10.0 #1316

Merged
merged 2 commits into from
May 12, 2024
Merged

Update sbt to 1.10.0 #1316

merged 2 commits into from
May 12, 2024

Conversation

scala-steward-asf[bot]
Copy link
Contributor

@scala-steward-asf scala-steward-asf bot commented May 7, 2024

About this PR

πŸ“¦ Updates org.scala-sbt:sbt from 1.9.9 to 1.10.0

πŸ“œ GitHub Release Notes - Version Diff

Usage

βœ… Please merge!

I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.

If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.

Configure Scala Steward for your repository with a .scala-steward.conf file.

Have a fantastic day writing Scala!

βš™ Adjust future updates

Add this to your .scala-steward.conf file to ignore future updates of this dependency:

updates.ignore = [ { groupId = "org.scala-sbt", artifactId = "sbt" } ]

Or, add this to slow down future updates of this dependency:

dependencyOverrides = [{
  pullRequests = { frequency = "30 days" },
  dependency = { groupId = "org.scala-sbt", artifactId = "sbt" }
}]
labels: library-update, early-semver-minor, semver-spec-minor, version-scheme:early-semver, commit-count:1

@He-Pin
Copy link
Member

He-Pin commented May 7, 2024

Not sure why, will look into this after work.
refs: sbt/sbt#7351

Copy link
Member

@He-Pin He-Pin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

Copy link
Member

@He-Pin He-Pin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will look into this soon

@He-Pin He-Pin force-pushed the update/sbt-1.10.0 branch from 64d219b to 232e15f Compare May 12, 2024 10:27
@pjfanning
Copy link
Contributor

+~ is custom and is defined in project/PekkoBuild.scala - if it is now broken, can we remove it from PekkoBuild and fix all uses?

There are uses in more files than the ones you are updating. +~ is used in a few of the nightly build jobs too.

Copy link
Contributor

@pjfanning pjfanning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you undo the changes to the name values in the yml files?

@He-Pin
Copy link
Member

He-Pin commented May 12, 2024

it's broken because the space between commands

@He-Pin
Copy link
Member

He-Pin commented May 12, 2024

I will revert the change about +~, but not the commands

@He-Pin He-Pin force-pushed the update/sbt-1.10.0 branch from 232e15f to 7455bf0 Compare May 12, 2024 11:11
@He-Pin He-Pin force-pushed the update/sbt-1.10.0 branch from 7455bf0 to 766f2ff Compare May 12, 2024 11:15
@He-Pin He-Pin requested a review from pjfanning May 12, 2024 11:17
Copy link
Contributor

@pjfanning pjfanning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm - pending CI

@He-Pin He-Pin merged commit ebcffc7 into main May 12, 2024
18 checks passed
@He-Pin He-Pin deleted the update/sbt-1.10.0 branch May 12, 2024 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants