Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix javadoc link to include module name #1292

Merged
merged 1 commit into from
Apr 25, 2024
Merged

Fix javadoc link to include module name #1292

merged 1 commit into from
Apr 25, 2024

Conversation

c00ler
Copy link
Contributor

@c00ler c00ler commented Apr 25, 2024

This PR fixes logback AsyncAppender javadoc link in the documentation.

Fixes #1291

@Roiocam
Copy link
Member

Roiocam commented Apr 25, 2024

Thanks @c00ler, Do you know if the website for logback has been migrated or if it was mistake changed due to a certain iteration? I created an issue but haven't received any reply. The slf4j under the same domain doesn't have a similar URL path.

Copy link
Member

@He-Pin He-Pin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@c00ler
Copy link
Contributor Author

c00ler commented Apr 25, 2024

Thanks @c00ler, Do you know if the website for logback has been migrated or if it was mistake changed due to a certain iteration? I created an issue but haven't received any reply. The slf4j under the same domain doesn't have a similar URL path.

@Roiocam I believe that the new url is an intentional and permanent change. The url is pointing to the latest javadoc that corresponds to version 1.5.x of logback. The latest version is using java modules (see module-info.java). The module name ch.qos.logback.classic just happens to be the same as the package and this is why in the url it looks like a duplicate, but its different. It looks like that logback 1.5.x is using Java 21 toolchain to create javadoc and the new javadoc layout includes information about modules. I've checked javadocs for older logback versions and the latest version that uses the old layout (without modules) is 1.3.14 (latest version from 1.3.x branch).

@pjfanning pjfanning merged commit 4c18284 into apache:main Apr 25, 2024
18 checks passed
@c00ler c00ler deleted the fix-javadoc-link branch April 25, 2024 09:05
pjfanning pushed a commit to pjfanning/incubator-pekko that referenced this pull request Apr 25, 2024
pjfanning added a commit that referenced this pull request Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Links validation job fails due to broken javadoc link
4 participants