Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove incubator notice #1216

Merged
merged 2 commits into from
Mar 24, 2024
Merged

remove incubator notice #1216

merged 2 commits into from
Mar 24, 2024

Conversation

pjfanning
Copy link
Contributor

appears in web site footers

@pjfanning pjfanning marked this pull request as draft March 22, 2024 16:12
Copy link
Contributor

@mdedetrich mdedetrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@pjfanning
Copy link
Contributor Author

pjfanning commented Mar 24, 2024

@mdedetrich I gave up on this because I could not get it to work for persistence-cassandra module.
See apache/pekko-persistence-cassandra#175 - all permutations of setting this flag that I have tried have no effect and the Incubator notice will not go away.

The docs in this module take so long to build that I want to get it to work in smaller modules first.

@pjfanning pjfanning marked this pull request as ready for review March 24, 2024 11:50
@pjfanning
Copy link
Contributor Author

@mdedetrich does this change look about right? Unfortunately, I don't have to test this on my laptop this afternoon.

@pjfanning
Copy link
Contributor Author

I ran this locally and it seems to work.

@pjfanning pjfanning merged commit ebf5c89 into main Mar 24, 2024
18 checks passed
@pjfanning pjfanning deleted the pjfanning-patch-1 branch March 24, 2024 21:38
pjfanning added a commit to pjfanning/incubator-pekko that referenced this pull request Mar 24, 2024
* remove incubator notice

* rework
pjfanning added a commit that referenced this pull request Mar 25, 2024
* remove incubator notice

* rework
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants