Get avoid snapshot interval calculate int overflow #1088
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andy.Chen <[email protected]>
pjfanning
approved these changes
Jan 31, 2024
|
@Roiocam Probably hard to test but could you consider if it's possible? |
|
@Roiocam just saw this in production @pjfanning |
|
@Roiocam Would you like to cherry pick this to 1.0.x ? Thanks. |
Yes, the reproduction can be implemented on |
Roiocam
added a commit
to Roiocam/pekko
that referenced
this pull request
Feb 1, 2024
Signed-off-by: Andy.Chen <[email protected]>
|
There is no need to write a plugin for just test this... |
I mean verified in such as pekko-persistence-jdbc |
He-Pin
pushed a commit
that referenced
this pull request
Feb 1, 2024
Signed-off-by: Andy.Chen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
When the user uses
Integer.MAX_VALUEas keepNSnapshots, it will touch integer overflow, and persistence will never delete those events.This change will not change anything besides avoid overflow, because the persistence actor version already designed as a long type.
This screenshot was happened in the real world: