chore: Fix ActorDocSpec on Scala 3.3 #1083
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This definitely compiles on Scala 2.12 and 2.13 as well? |
|
@pjfanning Runtime error on Scala 3.3 |
|
To clarify, is this fixing a compilation error that existed on Scala 3.3 or was the test (and possibly Pekko) running differently on Scala 3.3? |
We should probably report this on Dotty/Scala 3 then |
|
@mdedetrich @pjfanning runtime error, compiles fine, IIRC, scala.language.reflectiveCalls is removed and not sure why the code still compiles. |
|
I was encounter scala/scala3#16018 too. |
|
I will schedule a Test run locally on Scala 3.3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Fix ActorDocSpec
refs: #1081