-
Notifications
You must be signed in to change notification settings - Fork 147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update sbt-paradox to 0.10.6 #1061
Conversation
Tests fails (https://github.com/apache/incubator-pekko/actions/runs/7681954241/job/20935690091?pr=1061#step:7:32954)
Parboiled upgrades from 1.3.1 to 1.4.1: lightbend/paradox@v0.9.2...v0.10.6#diff-ad2642dc77b3679e4ad2c7d3b2f59a2dcf48c1bf5b93a558a4fa44828315a34cR23 1.4.1 drops support for Java 8: https://github.com/sirthias/parboiled/blob/7f6d999ba9a838ea760f00a1dc85eac91ed515e6/CHANGELOG#L1-L4 Solution might be to force use version 1.4.0? What do you think? |
Ah ok I just saw this comment // We have to deliberately use older versions of sbt-paradox because current Pekko sbt build
// only loads on JDK 1.8 so we need to bring in older versions of parboiled which support JDK 1.8 How about instead of holding back all those paradox dependencies, using |
@mkurz is the sbt repo being shut down? We have a lot of other stuff going on and it would be a pain to drop everything to to focus on paradox builds. |
@pjfanning No, it's not shutting down. But who knows when it's going down again. It's not urgent, I just want to raise awareness and start migrating stuff that hasn't yet, not much missing actually. I can already build and test Play locally by only using maven central dependencies. |
Actually, bumping sbt-paradox to 0.10.6 is the last piece missing to make pekko compile and test with having repo.scala-sbt.org blocked (of course with all artifacts from that repo removed from the local cache). |
if this works sure Another solution would be to make sbt-paradox have another release in the 0.9.x series onto the new repo (maybe even backporting some fixes!) but I am not sure if thats on the table |
8e401ce
to
92c4cd5
Compare
92c4cd5
to
5fd3135
Compare
5fd3135
to
62def54
Compare
Closing this for now since this problem is being solved another way |
About this PR
π¦ Updates com.lightbend.paradox:sbt-paradox from
0.9.2
to0.10.6
π GitHub Release Notes - Version Diff
Usage
β Please merge!
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a
.scala-steward.conf
file.Have a fantastic day writing Scala!
β Adjust future updates
Add this to your
.scala-steward.conf
file to ignore future updates of this dependency:Or, add this to slow down future updates of this dependency: