-
Notifications
You must be signed in to change notification settings - Fork 151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate org.apache.pekko.dispatch.Futures
#1417
Comments
I had a quick look at this and I think this Futures class is useful. See #1418 for the PR that convinced that this change is not a good idea. |
Sketching out apache#1417 - incomplete and notably not bothering with binary compatibility yet, just to illustrate the idea.
I didn't intend to suggest Java users should use Something along the lines of (sketch) https://github.com/apache/pekko/compare/main...raboof:pekko:no-scala-futures-in-java?expand=1 The |
90% of the internal Pekko usages of org.apache.pekko.dispatch.Futures are in Java unit tests. FutureTimeoutSupport has one usage that could moved internal to that class. |
Sketching out apache#1417 - incomplete and notably not bothering with binary compatibility yet, just to illustrate the idea.
Sketching out apache#1417 - incomplete and notably not bothering with binary compatibility yet, just to illustrate the idea.
Sketching out apache#1417 - incomplete and notably not bothering with binary compatibility yet, just to illustrate the idea.
Sketching out apache#1417 - incomplete and notably not bothering with binary compatibility yet, just to illustrate the idea.
I think this class was introduced when Akka still supported Java versions before Java 8, which introduced
CompletionStage
.We should probably try and deprecate
org.apache.pekko.dispatch.Futures
and any Java APIs that still produce/expectFuture
s, and introduce ones that work withCompletionStage
.The text was updated successfully, but these errors were encountered: