Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mima check on pull requests #312

Closed
wants to merge 1 commit into from

Conversation

pjfanning
Copy link
Contributor

@He-Pin
Copy link
Member

He-Pin commented Aug 31, 2023

I ran the mimaReportBinaryIssues locally and it work.

Copy link
Member

@He-Pin He-Pin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

better to have a dedicated binary-compatibility-checks workflow like pekko

@mdedetrich
Copy link
Contributor

mdedetrich commented Sep 1, 2023

Can we also please make a decision on https://lists.apache.org/thread/4oymvkv6t415pocdtc6l1vxssoflbw9f and apache/pekko#532 ? The whole point of that thread/PR is to actually implement a proper handling of MiMa that sticks to semver and actually automatically deals with changes where people add functionality (doing MiMa checks against a hardcoded Pekko 1.0.0/1.1.0 is not enough, we should actually be doing MiMa checks against the latest release of the software against every PR).

I understand the solution may not be the cleanest (although tbh we kind of have our hands tied due to ASF process) but what I am suggesting is standard and normal in Scala OS projects, its not some crazy out there idea (otherwise this feature in dynver wouldn't even exist).

@pjfanning pjfanning closed this Sep 3, 2023
@He-Pin He-Pin reopened this Sep 7, 2023
He-Pin

This comment was marked as resolved.

@He-Pin He-Pin closed this Sep 7, 2023
@pjfanning pjfanning deleted the mima-check-pull-requests branch September 12, 2023 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants