Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: fuse handlers in CancellationBarrierGraphStage #414

Merged
merged 1 commit into from
Nov 28, 2024
Merged

chore: fuse handlers in CancellationBarrierGraphStage #414

merged 1 commit into from
Nov 28, 2024

Conversation

He-Pin
Copy link
Member

@He-Pin He-Pin commented Nov 28, 2024

Motivation:
Fuse the inHandler and outHandler to reduce memory usage.

raboof
raboof approved these changes Nov 28, 2024
View reviewed changes
Copy link
Member

@raboof raboof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm surprised this'd make a noticable difference, but the new code is at least as readable as the old, so 👍

I wonder if we should propose this component for inclusion in pekko-streams.

@He-Pin
Copy link
Member Author

He-Pin commented Nov 28, 2024

Yeah, I was working on our internal grpc based implementation and just found this, it's more readable now.

@He-Pin He-Pin merged commit 65d3683 into main Nov 28, 2024
22 of 23 checks passed
@He-Pin He-Pin deleted the cancelHandler branch November 28, 2024 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raboof raboof raboof approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@He-Pin @raboof