Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update google-cloud-pubsub to 1.134.2 #907

Closed
wants to merge 2 commits into from

Conversation

scala-steward-asf[bot]
Copy link
Contributor

@scala-steward-asf scala-steward-asf bot commented Nov 24, 2024

About this PR

πŸ“¦ Updates com.google.cloud:google-cloud-pubsub from 1.133.1 to 1.134.2

πŸ“œ GitHub Release Notes - Version Diff

Usage

βœ… Please merge!

I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.

If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.

Configure Scala Steward for your repository with a .scala-steward.conf file.

Have a fantastic day writing Scala!

βš™ Adjust future updates

Add this to your .scala-steward.conf file to ignore future updates of this dependency:

updates.ignore = [ { groupId = "com.google.cloud", artifactId = "google-cloud-pubsub" } ]

Or, add this to slow down future updates of this dependency:

dependencyOverrides = [{
  pullRequests = { frequency = "30 days" },
  dependency = { groupId = "com.google.cloud", artifactId = "google-cloud-pubsub" }
}]
labels: library-update, early-semver-minor, semver-spec-minor, commit-count:1

@pjfanning pjfanning marked this pull request as draft November 24, 2024 15:39
@pjfanning
Copy link
Contributor

see #882

@scala-steward-asf scala-steward-asf bot force-pushed the update/google-cloud-pubsub-1.134.2 branch from 0d8ae8e to c64a580 Compare December 1, 2024 02:40
@scala-steward-asf scala-steward-asf bot force-pushed the update/google-cloud-pubsub-1.134.2 branch from c64a580 to ef95188 Compare December 8, 2024 02:37
@pjfanning
Copy link
Contributor

@raboof @He-Pin @Roiocam I'm tempted to merge this.

We already have merged amazon-kinesis-client:3.0.1 and this also brings in a Protobuf-Java v4 dependency.

This PR doesn't break any unit tests.

From what I've read Protobuf-Java v4 is expected to work in almost all cases where the original libs that use it were compiled with comparatively recent Protobuf-Java v3 dependencies.

It just seems more complicated to have to analyse every Scala Steward PR to see if it might contain a transitive dependency on Protobuf-Java v4. It's easier to rely on the build and tests to see if the PR breaks anything.

@raboof
Copy link
Member

raboof commented Dec 16, 2024

From what I've read Protobuf-Java v4 is expected to work in almost all cases where the original libs that use it were compiled with comparatively recent Protobuf-Java v3 dependencies.

Cool

It's easier to rely on the build and tests to see if the PR breaks anything.

This seems sensible to me

@pjfanning pjfanning marked this pull request as ready for review December 16, 2024 15:31
@pjfanning
Copy link
Contributor

#924 covers this already

@pjfanning pjfanning closed this Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants