docker-compose changes (#764) #765
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pjfanning
force-pushed
the
docker-backport
branch
from
16b20d1 to
189c345
Compare
revert kudu change Update check-build-test.yml
pjfanning
force-pushed
the
docker-backport
branch
from
189c345 to
2f392db
Compare
Roiocam
approved these changes
Aug 6, 2024
| - "8091-8094:8091-8094" | ||
| - "11210:11210" | ||
| - "8091-8096:8091-8096" | ||
| - "11210-11211:11210-11211" |
There was a problem hiding this comment.
didn't notice this on the previous PR, Is it verified?
There was a problem hiding this comment.
- this change is from Support Couchbase3 #624
- the couchbase tests pass when I copy back this change but they fail if I leave the values as is
- the tests are not run on the 1.0.x branch unless we have a PR and unfortunately the GitHub CI changes to remove support for Docker v1 require us to update some of our docker-compose configs
- It's possible that the port changes are not all needed but I thought it was better to not customise the changes and just to try to keep the docker config that works in the main branch and use it in the 1.0.x branch too
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cherry pick 7f8736a #764