Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Pekko #288

Merged
merged 1 commit into from
Dec 2, 2023
Merged

Update Pekko #288

merged 1 commit into from
Dec 2, 2023

Conversation

mdedetrich
Copy link
Contributor

@mdedetrich mdedetrich commented Dec 2, 2023

Updates Pekko to 1.0.2

@mdedetrich
Copy link
Contributor Author

@pjfanning Was there some change in Pekko 1.0.2 that would cause pekko-connectors to fail to compile, specifically for the xml module?

@pjfanning
Copy link
Contributor

@pjfanning Was there some change in Pekko 1.0.2 that would cause pekko-connectors to fail to compile, specifically for the xml module?

not sure why this is happening but the logs don't highlight a compile issue, maybe there is a compile warning now and the build is set up to fail with compile warnings?

@mdedetrich
Copy link
Contributor Author

not sure why this is happening but the logs don't highlight a compile issue, maybe there is a compile warning now and the build is set up to fail with compile warnings?

Let me confirm this then, it's suspicious that the build fail didn't occur in the PR that changed the compile warnings.

@mdedetrich mdedetrich force-pushed the update-pekko-version branch 2 times, most recently from b3401ab to 0955226 Compare December 2, 2023 12:16
@mdedetrich
Copy link
Contributor Author

Okay so the nowarning's did fix the issue, everything is good now

Copy link
Contributor

@pjfanning pjfanning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mdedetrich mdedetrich merged commit 3e0a1c2 into apache:main Dec 2, 2023
48 of 50 checks passed
@mdedetrich mdedetrich deleted the update-pekko-version branch December 2, 2023 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants