Properly fix versioning for Pekko dependencies #271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdedetrich
force-pushed
the
don't-use-current-for-pekko-grpc-version
branch
2 times, most recently
from
0075004 to
f620a81
Compare
mdedetrich
changed the title
mdedetrich
force-pushed
the
don't-use-current-for-pekko-grpc-version
branch
from
f620a81 to
7c04bed
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a regression in 2b5fcd1#diff-ad2642dc77b3679e4ad2c7d3b2f59a2dcf48c1bf5b93a558a4fa44828315a34cR29 where the Pekko dependencies were set to "current" (likely because a grpc release wasn't made) but in reality its actually meant to be a statically hardcoded version.
You can use https://github.com/mdedetrich/alpakka-apache/blob/4ebf24a4f996b088b4ed16cee182accc5ac92e1c/project/Dependencies.scala#L16-L21 as a reference of how it looked like at last point before fork