Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary license comments #260

Merged

Conversation

mdedetrich
Copy link
Contributor

@mdedetrich mdedetrich commented Oct 9, 2023

I think this was done before but because of issues when rebasing the scala3 branch the changes were lost. In any case, these comments are unnecessary because sbt-license-report does the same job (and more correctly since it actually scans the dependency tree).

@mdedetrich mdedetrich force-pushed the remove-unnecessary-license-comments branch from c57baa7 to c1722fe Compare October 9, 2023 09:13
Copy link
Contributor

@pjfanning pjfanning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mdedetrich mdedetrich merged commit 867d809 into apache:main Oct 9, 2023
50 checks passed
@mdedetrich mdedetrich deleted the remove-unnecessary-license-comments branch October 9, 2023 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants