Skip to content

Commit

Permalink
PDFBOX-5847: Improve performance of FileSystemFontProvider.scanFonts(…
Browse files Browse the repository at this point in the history
…) by introducing an "only headers" mode for the font parsers where each table reads as little information as possible, by Mykola Bohdiuk

git-svn-id: https://svn.apache.org/repos/asf/pdfbox/trunk@1918773 13f79535-47bb-0310-9956-ffa450edef68
  • Loading branch information
THausherr committed Jul 1, 2024
1 parent 0bc5dac commit ed6def6
Show file tree
Hide file tree
Showing 14 changed files with 938 additions and 214 deletions.
115 changes: 95 additions & 20 deletions fontbox/src/main/java/org/apache/fontbox/cff/CFFParser.java
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@
import org.apache.logging.log4j.Logger;
import org.apache.logging.log4j.LogManager;

import org.apache.fontbox.ttf.FontHeaders;
import org.apache.pdfbox.io.RandomAccessRead;


Expand Down Expand Up @@ -67,6 +68,60 @@ public interface ByteSource
byte[] getBytes() throws IOException;
}

/**
* Extract "Registry", "Ordering" and "Supplement" properties from the first CFF subfont.
*
* @param randomAccessRead the source to be parsed
* @param outHeaders where to put results
* @throws IOException If there is an error reading from the stream
*/
public void parseFirstSubFontROS(RandomAccessRead randomAccessRead, FontHeaders outHeaders) throws IOException
{
// this method is a simplified and merged version of parse(RandomAccessRead) > parse(DataInput) > parseFont(...)

// start code from parse(RandomAccessRead)
randomAccessRead.seek(0);
DataInput input = new DataInputRandomAccessRead(randomAccessRead);

// start code from parse(DataInput)
input = skipHeader(input);
String[] nameIndex = readStringIndexData(input);
if (nameIndex.length == 0)
{
outHeaders.setError("Name index missing in CFF font");
return;
}
byte[][] topDictIndex = readIndexData(input);
if (topDictIndex.length == 0)
{
outHeaders.setError("Top DICT INDEX missing in CFF font");
return;
}

// 'stringIndex' is required by 'parseROS() > readString()'
stringIndex = readStringIndexData(input);

// start code from parseFont(...)
DataInputByteArray topDictInput = new DataInputByteArray(topDictIndex[0]);
DictData topDict = readDictData(topDictInput);

DictData.Entry syntheticBaseEntry = topDict.getEntry("SyntheticBase");
if (syntheticBaseEntry != null)
{
outHeaders.setError("Synthetic Fonts are not supported");
return;
}

CFFCIDFont cffCIDFont = parseROS(topDict);
if (cffCIDFont != null)
{
outHeaders.setOtfROS(
cffCIDFont.getRegistry(),
cffCIDFont.getOrdering(),
cffCIDFont.getSupplement());
}
}

/**
* Parse CFF font using byte array, also passing in a byte source for future use.
*
Expand Down Expand Up @@ -106,14 +161,7 @@ public List<CFFFont> parse(RandomAccessRead randomAccessRead) throws IOException
return parse(new DataInputRandomAccessRead(randomAccessRead));
}

/**
* Parse CFF font using a DataInput as input.
*
* @param input the source to be parsed
* @return the parsed CFF fonts
* @throws IOException If there is an error reading from the stream
*/
private List<CFFFont> parse(DataInput input) throws IOException
private DataInput skipHeader(DataInput input) throws IOException
{
String firstTag = readTagName(input);
// try to determine which kind of font we have
Expand All @@ -133,6 +181,19 @@ private List<CFFFont> parse(DataInput input) throws IOException

@SuppressWarnings("unused")
Header header = readHeader(input);
return input;
}

/**
* Parse CFF font using a DataInput as input.
*
* @param input the source to be parsed
* @return the parsed CFF fonts
* @throws IOException If there is an error reading from the stream
*/
private List<CFFFont> parse(DataInput input) throws IOException
{
input = skipHeader(input);
String[] nameIndex = readStringIndexData(input);
if (nameIndex.length == 0)
{
Expand Down Expand Up @@ -464,6 +525,28 @@ private static Double readRealNumber(DataInput input) throws IOException
}
}

/**
* Extracts Registry, Ordering and Supplement from {@code topDict["ROS"]}.
*/
private CFFCIDFont parseROS(DictData topDict) throws IOException
{
// determine if this is a Type 1-equivalent font or a CIDFont
DictData.Entry rosEntry = topDict.getEntry("ROS");
if (rosEntry != null)
{
if (rosEntry.size() < 3)
{
throw new IOException("ROS entry must have 3 elements");
}
CFFCIDFont cffCIDFont = new CFFCIDFont();
cffCIDFont.setRegistry(readString(rosEntry.getNumber(0).intValue()));
cffCIDFont.setOrdering(readString(rosEntry.getNumber(1).intValue()));
cffCIDFont.setSupplement(rosEntry.getNumber(2).intValue());
return cffCIDFont;
}
return null;
}

private CFFFont parseFont(DataInput input, String name, byte[] topDictIndex) throws IOException
{
// top dict
Expand All @@ -479,19 +562,11 @@ private CFFFont parseFont(DataInput input, String name, byte[] topDictIndex) thr

// determine if this is a Type 1-equivalent font or a CIDFont
CFFFont font;
boolean isCIDFont = topDict.getEntry("ROS") != null;
if (isCIDFont)
CFFCIDFont cffCIDFont = parseROS(topDict);
// determine if this is a Type 1-equivalent font or a CIDFont
boolean isCIDFont = cffCIDFont != null;
if (cffCIDFont != null)
{
CFFCIDFont cffCIDFont = new CFFCIDFont();
DictData.Entry rosEntry = topDict.getEntry("ROS");
if (rosEntry == null || rosEntry.size() < 3)
{
throw new IOException("ROS entry must have 3 elements");
}
cffCIDFont.setRegistry(readString(rosEntry.getNumber(0).intValue()));
cffCIDFont.setOrdering(readString(rosEntry.getNumber(1).intValue()));
cffCIDFont.setSupplement(rosEntry.getNumber(2).intValue());

font = cffCIDFont;
}
else
Expand Down
197 changes: 110 additions & 87 deletions fontbox/src/main/java/org/apache/fontbox/ttf/CFFTable.java
Original file line number Diff line number Diff line change
@@ -1,87 +1,110 @@
/*
* Licensed to the Apache Software Foundation (ASF) under one or more
* contributor license agreements. See the NOTICE file distributed with
* this work for additional information regarding copyright ownership.
* The ASF licenses this file to You under the Apache License, Version 2.0
* (the "License"); you may not use this file except in compliance with
* the License. You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/

package org.apache.fontbox.ttf;

import java.io.IOException;
import org.apache.fontbox.cff.CFFFont;
import org.apache.fontbox.cff.CFFParser;

/**
* PostScript font program (compact font format).
*/
public class CFFTable extends TTFTable
{
/**
* A tag that identifies this table type.
*/
public static final String TAG = "CFF ";

private CFFFont cffFont;

CFFTable()
{
super();
}

/**
* This will read the required data from the stream.
*
* @param ttf The font that is being read.
* @param data The stream to read the data from.
* @throws java.io.IOException If there is an error reading the data.
*/
@Override
void read(TrueTypeFont ttf, TTFDataStream data) throws IOException
{
byte[] bytes = data.read((int)getLength());

CFFParser parser = new CFFParser();
cffFont = parser.parse(bytes, new CFFBytesource(ttf)).get(0);

initialized = true;
}

/**
* Returns the CFF font, which is a compact representation of a PostScript Type 1, or CIDFont
*
* @return the associated CFF font
*/
public CFFFont getFont()
{
return cffFont;
}

/**
* Allows bytes to be re-read later by CFFParser.
*/
private static class CFFBytesource implements CFFParser.ByteSource
{
private final TrueTypeFont ttf;

CFFBytesource(TrueTypeFont ttf)
{
this.ttf = ttf;
}

@Override
public byte[] getBytes() throws IOException
{
return ttf.getTableBytes(ttf.getTableMap().get(CFFTable.TAG));
}
}
}
/*
* Licensed to the Apache Software Foundation (ASF) under one or more
* contributor license agreements. See the NOTICE file distributed with
* this work for additional information regarding copyright ownership.
* The ASF licenses this file to You under the Apache License, Version 2.0
* (the "License"); you may not use this file except in compliance with
* the License. You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/

package org.apache.fontbox.ttf;

import java.io.IOException;
import org.apache.fontbox.cff.CFFFont;
import org.apache.fontbox.cff.CFFParser;
import org.apache.pdfbox.io.RandomAccessRead;
import org.apache.pdfbox.io.RandomAccessReadBuffer;

/**
* PostScript font program (compact font format).
*/
public class CFFTable extends TTFTable
{
/**
* A tag that identifies this table type.
*/
public static final String TAG = "CFF ";

private CFFFont cffFont;

CFFTable()
{
super();
}

/**
* This will read the required data from the stream.
*
* @param ttf The font that is being read.
* @param data The stream to read the data from.
* @throws java.io.IOException If there is an error reading the data.
*/
@Override
void read(TrueTypeFont ttf, TTFDataStream data) throws IOException
{
byte[] bytes = data.read((int)getLength());

CFFParser parser = new CFFParser();
cffFont = parser.parse(bytes, new CFFBytesource(ttf)).get(0);

initialized = true;
}

/** {@inheritDoc} */
@Override
void readHeaders(TrueTypeFont ttf, TTFDataStream data, FontHeaders outHeaders) throws IOException
{
try (RandomAccessRead subReader = data.createSubView(getLength()))
{
RandomAccessRead reader;
if (subReader != null)
{
reader = subReader;
}
else
{
assert false : "It is inefficient to read TTFDataStream into an array";
byte[] bytes = data.read((int)getLength());
reader = new RandomAccessReadBuffer(bytes);
}
new CFFParser().parseFirstSubFontROS(reader, outHeaders);
}
}

/**
* Returns the CFF font, which is a compact representation of a PostScript Type 1, or CIDFont
*
* @return the associated CFF font
*/
public CFFFont getFont()
{
return cffFont;
}

/**
* Allows bytes to be re-read later by CFFParser.
*/
private static class CFFBytesource implements CFFParser.ByteSource
{
private final TrueTypeFont ttf;

CFFBytesource(TrueTypeFont ttf)
{
this.ttf = ttf;
}

@Override
public byte[] getBytes() throws IOException
{
return ttf.getTableBytes(ttf.getTableMap().get(CFFTable.TAG));
}
}
}
Loading

0 comments on commit ed6def6

Please sign in to comment.