GH-3059: Add configuration to disable size statistics #3060
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you please take a look? Thanks! @gszadovszky @Fokko |
Fokko
reviewed
Nov 15, 2024
| writer.write(group); | ||
| writer.close(); | ||
|
|
||
| ParquetFileReader reader = ParquetFileReader.open(HadoopInputFile.fromPath(path, new Configuration())); |
There was a problem hiding this comment.
Nit: I prefer to also use try-with-resource in the tests to give a good example :)
There was a problem hiding this comment.
Thanks for your review! Changed it to use try-with-resource now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Now size statistics are enabled globally. We need to better control the behavior when it is not necessary.
What changes are included in this PR?
Add a new flag
parquet.size.statistics.enabledto control whether to enable size statistics globally. It also supports a per-column control.Are these changes tested?
Yes, added a test case in TestParquetWriter.java.
Are there any user-facing changes?
Yes, a new flag
parquet.size.statistics.enabledhas been added.Closes #3059