-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MINOR: ParquetRewriter must close opened reader/stream #3002
Conversation
if reader not closed, open parquet files in cannot be deleted.
anything you want me to do ? i dont know why pipeline fails !!! |
Calling close() may throw IOException. |
i got it. i will solve (tomorrow date hour) thanks. |
initNextReader() method has 2 usage and both of them already throws IOException public ParquetRewriter(RewriteOptions options) throws IOException public void processBlocks() throws IOException
thanks for your fast answer |
Is it indentation and white Space problem? |
i combined "reader.close();" command with "if" clouse (one line) |
fix: white space is added after if |
fix: mvn spotless:apply command is run. |
I just merged it. Thanks @cetindogu and @Fokko! |
When can i see the new package in maven repo? |
We will not see it until the next release, e.g. 1.15.0. |
if reader not closed, open parquet files in cannot be deleted.
Rationale for this change
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?