GH-2988: Supports disabling statistics for specific columns #2989
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wgtmac
reviewed
Aug 16, 2024
| this.sizeStatisticsBuilder = SizeStatistics.newBuilder( | ||
| path.getPrimitiveType(), path.getMaxRepetitionLevel(), path.getMaxDefinitionLevel()); | ||
| } | ||
|
|
||
| void writeNull(int repetitionLevel, int definitionLevel) { | ||
| statistics.incrementNumNulls(); | ||
| if (statistics != null) { |
There was a problem hiding this comment.
Can we create a NoopStatistics so we don't need to this check? The point of ColumnValueCollector class is to avoid any condition as it is in the critical path.
There was a problem hiding this comment.
Changed to NoopStatistics
This was referenced Nov 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Closes #2988
What changes are included in this PR?
Supports config
Are these changes tested?
New UTs.
Supports disabling statistics for specific columns by configuration.
Are there any user-facing changes?
The existing code does not need changes.
Closes #2988