Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PARQUET-2498: Vector IO to handle empty range list #1374

Merged

Conversation

steveloughran
Copy link
Contributor

Empty range lists currently trigger IllegalArgumentException,
however some (integration test) codepaths attempt to do this.

Downgrading the empty list case to a no-op resolves this.

Change-Id: Ia0f94422415aeeacb15d3c3a909d4de6f1563268

Make sure you have checked all steps below.

Jira

Tests

  • My PR adds the following unit tests
TestVectorIoBridge.testEmptyRangeList()

Commits

  • [X ] My commits all reference Jira issues in their subject lines. In addition, my commits follow the guidelines
    from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Style

  • My contribution adheres to the code style guidelines and Spotless passes.
    • To apply the necessary changes, run mvn spotless:apply -Pvector-plugins

Documentation

  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain Javadoc that explain what it does

Empty range lists currently trigger IllegalArgumentException,
however some (integration test) codepaths attempt to do this.

Downgrading the empty list case to a no-op resolves this.

Contributed by Steve Loughran

Change-Id: I07ed7e8f0628e170441a2d0679e822d23cfb1440
Copy link
Member

@wgtmac wgtmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@wgtmac
Copy link
Member

wgtmac commented Jun 13, 2024

Do we need to port it to the version 1.14.1 which is about to release?

@wgtmac wgtmac changed the title PARQUET-2498. Vector IO to handle empty range list PARQUET-2498: Vector IO to handle empty range list Jun 13, 2024
@wgtmac wgtmac merged commit 26268c9 into apache:master Jun 13, 2024
9 checks passed
wgtmac pushed a commit that referenced this pull request Jun 13, 2024
Empty range lists currently trigger IllegalArgumentException,
however some (integration test) codepaths attempt to do this.

Downgrading the empty list case to a no-op resolves this.

Contributed by Steve Loughran

Change-Id: I07ed7e8f0628e170441a2d0679e822d23cfb1440
@steveloughran
Copy link
Contributor Author

yes, please.

@wgtmac
Copy link
Member

wgtmac commented Jun 14, 2024

I already included that in the 1.14.1 RC0 :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants