Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PARQUET-2363: ParquetRewriter should encrypt the V2 page header #1169

Merged
merged 1 commit into from
Oct 15, 2023

Conversation

ConeyLiu
Copy link
Contributor

@ConeyLiu ConeyLiu commented Oct 13, 2023

Make sure you have checked all steps below.

This PR adds support for encrypting the V2 page header when encrypting/re-encrypting files.

Jira

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:

Commits

  • My commits all reference Jira issues in their subject lines. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Documentation

  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain Javadoc that explain what it does

rlByteLength,
dlByteLength,
out);
if (pageWriteChecksumEnabled) {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add the CRC for the v2 page as well.

@ConeyLiu
Copy link
Contributor Author

Hi @wgtmac, please help to review this when you are free. Thanks a lot.

Copy link
Member

@wgtmac wgtmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot! LGTM.

@wgtmac wgtmac merged commit 5ee5133 into apache:master Oct 15, 2023
9 checks passed
@ConeyLiu
Copy link
Contributor Author

Thanks @wgtmac

@ConeyLiu ConeyLiu deleted the v2-crc branch October 16, 2023 03:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants