Skip to content

Commit

Permalink
PARQUET-787: Fix problems from Zoltan's review.
Browse files Browse the repository at this point in the history
  • Loading branch information
rdblue committed Dec 1, 2017
1 parent c90f36d commit 9e72839
Show file tree
Hide file tree
Showing 2 changed files with 16 additions and 20 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -46,9 +46,7 @@ public FixedLenByteArrayPlainValuesReader(int length) {
public Binary readBytes() {
try {
return Binary.fromConstantByteBuffer(in.slice(length));
} catch (IOException e) {
throw new ParquetDecodingException("could not read bytes at offset " + in.position(), e);
} catch (RuntimeException e) {
} catch (IOException | RuntimeException e) {
throw new ParquetDecodingException("could not read bytes at offset " + in.position(), e);
}
}
Expand All @@ -57,9 +55,7 @@ public Binary readBytes() {
public void skip() {
try {
in.skipFully(length);
} catch (IOException e) {
throw new ParquetDecodingException("could not skip bytes at offset " + in.position(), e);
} catch (RuntimeException e) {
} catch (IOException | RuntimeException e) {
throw new ParquetDecodingException("could not skip bytes at offset " + in.position(), e);
}
}
Expand Down
Original file line number Diff line number Diff line change
@@ -1,20 +1,20 @@
/*
* Licensed to the Apache Software Foundation (ASF) under one
* or more contributor license agreements. See the NOTICE file
* distributed with this work for additional information
* regarding copyright ownership. The ASF licenses this file
* to you under the Apache License, Version 2.0 (the
* "License"); you may not use this file except in compliance
* with the License. You may obtain a copy of the License at
* Licensed to the Apache Software Foundation (ASF) under one
* or more contributor license agreements. See the NOTICE file
* distributed with this work for additional information
* regarding copyright ownership. The ASF licenses this file
* to you under the Apache License, Version 2.0 (the
* "License"); you may not use this file except in compliance
* with the License. You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing,
* software distributed under the License is distributed on an
* "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
* KIND, either express or implied. See the License for the
* specific language governing permissions and limitations
* under the License.
* Unless required by applicable law or agreed to in writing,
* software distributed under the License is distributed on an
* "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
* KIND, either express or implied. See the License for the
* specific language governing permissions and limitations
* under the License.
*/

package org.apache.parquet.bytes;
Expand Down

0 comments on commit 9e72839

Please sign in to comment.