-
Notifications
You must be signed in to change notification settings - Fork 952
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[core] Support commit metrics #1638
Conversation
paimon-core/src/main/java/org/apache/paimon/metrics/commit/CommitMetrics.java
Show resolved
Hide resolved
paimon-core/src/main/java/org/apache/paimon/metrics/commit/CommitMetrics.java
Outdated
Show resolved
Hide resolved
paimon-core/src/main/java/org/apache/paimon/metrics/commit/CommitStats.java
Outdated
Show resolved
Hide resolved
paimon-core/src/main/java/org/apache/paimon/metrics/commit/CommitStats.java
Outdated
Show resolved
Hide resolved
paimon-core/src/main/java/org/apache/paimon/metrics/commit/CommitStats.java
Outdated
Show resolved
Hide resolved
paimon-core/src/main/java/org/apache/paimon/AbstractFileStore.java
Outdated
Show resolved
Hide resolved
paimon-core/src/main/java/org/apache/paimon/operation/FileStoreCommitImpl.java
Outdated
Show resolved
Hide resolved
paimon-core/src/main/java/org/apache/paimon/operation/FileStoreCommitImpl.java
Outdated
Show resolved
Hide resolved
paimon-core/src/main/java/org/apache/paimon/metrics/commit/CommitMetrics.java
Outdated
Show resolved
Hide resolved
Remove total- metrics, which is more suitable to query system files table. |
232a167
to
5b822ad
Compare
paimon-core/src/main/java/org/apache/paimon/metrics/commit/CommitStats.java
Outdated
Show resolved
Hide resolved
paimon-core/src/main/java/org/apache/paimon/operation/FileStoreCommitImpl.java
Outdated
Show resolved
Hide resolved
paimon-core/src/main/java/org/apache/paimon/table/sink/TableCommitImpl.java
Outdated
Show resolved
Hide resolved
45ea034
to
b334ea2
Compare
paimon-core/src/main/java/org/apache/paimon/operation/FileStoreCommitImpl.java
Show resolved
Hide resolved
paimon-core/src/main/java/org/apache/paimon/table/sink/TableCommitImpl.java
Outdated
Show resolved
Hide resolved
paimon-core/src/test/java/org/apache/paimon/operation/FileDeletionTest.java
Outdated
Show resolved
Hide resolved
45c7744
to
adff8fb
Compare
paimon-core/src/main/java/org/apache/paimon/metrics/commit/CommitMetrics.java
Show resolved
Hide resolved
paimon-core/src/test/java/org/apache/paimon/metrics/commit/CommitMetricsTest.java
Show resolved
Hide resolved
71fc83e
to
d8885b0
Compare
d8885b0
to
60e6a03
Compare
…e metrics group from other commit objs
60e6a03
to
7e8319c
Compare
b697e0f
to
990dbda
Compare
try { | ||
assertThat(Metrics.getInstance().getMetricGroups().size()).isEqualTo(1); | ||
} catch (AssertionError e) { | ||
error = | ||
ExceptionUtils.firstOrSuppressed( | ||
e, | ||
new AssertionError( | ||
"Please close the created TableCommit objects in case of metrics resource leak.")); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
try { | |
assertThat(Metrics.getInstance().getMetricGroups().size()).isEqualTo(1); | |
} catch (AssertionError e) { | |
error = | |
ExceptionUtils.firstOrSuppressed( | |
e, | |
new AssertionError( | |
"Please close the created TableCommit objects in case of metrics resource leak.")); | |
} | |
assertThat(Metrics.getInstance().getMetricGroups().size()).isEqualTo(1).withFailMessage(xxx); |
Please close the created TableCommit objects
-> Please close the created metric groups
. In the future we're going to add more metrics aside from commit metrics.
You might want to add a helper method to print out all metric group objects, so developers can see what kinds of metric groups are not closed.
Purpose
Linked issue: close #1468