[core][bug] readers don't close while io exception happening #1037
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ers cached in the list will lose control (apache#1036)
tsreaper
reviewed
Apr 26, 2023
| // if one of the readers creating failed, we need to close them all. | ||
| try { | ||
| for (SortedRun run : section) { | ||
| readers.add(readerForRun(run, readerFactory)); |
There was a problem hiding this comment.
readerForRun is also used in ChangelogMergeTreeRewriter#rewriteChangelogCompaction. Consider creating a method List<RecordReader<KeyValue>> readerListForSection(List<SortedRun> section, KeyValueFileReaderFactory readerFactory).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
readers don't close while io exception happening, the readers cached in the list will lose control (#1036)
Purpose
(What is the purpose of the change, or the associated issue)
Tests
(List UT and IT cases to verify this change)
API and Format
(Does this change affect API or storage format)
Documentation
(Does this change introduce a new feature)