-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ORC-FORMAT-6: Add CompressionKind.BROTLI
#7
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cc @deshanxiao, @williamhyun , @wgtmac |
williamhyun
approved these changes
Dec 8, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 LGTM
I'll be merging this now.
Thank you so much, @williamhyun ! |
+1 Thank you @dongjoon-hyun . Sorry for my late response. |
Thank you, @deshanxiao . No problem. :) |
dongjoon-hyun
added a commit
to apache/orc
that referenced
this pull request
Dec 9, 2023
### What changes were proposed in this pull request? This PR aims to use `orc-format` `1.0.0-beta`. ### Why are the changes needed? `1.0.0-beta` has the following changes. - apache/orc-format#5 - apache/orc-format#4 - apache/orc-format#7 - apache/orc-format#9 ### How was this patch tested? Pass the CIs. Closes #1688 from dongjoon-hyun/ORC-1551. Authored-by: Dongjoon Hyun <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]>
cxzl25
pushed a commit
to cxzl25/orc
that referenced
this pull request
Jan 11, 2024
### What changes were proposed in this pull request? This PR aims to use `orc-format` `1.0.0-beta`. ### Why are the changes needed? `1.0.0-beta` has the following changes. - apache/orc-format#5 - apache/orc-format#4 - apache/orc-format#7 - apache/orc-format#9 ### How was this patch tested? Pass the CIs. Closes apache#1688 from dongjoon-hyun/ORC-1551. Authored-by: Dongjoon Hyun <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This closes #6 by adding
CompressionKind.BROTLI
as a new compression type.Why are the changes needed?
To support ORC-1463 at Apache ORC Format 1.0.0.
How was this patch tested?
Pass the CIs.