Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not delete previous annotation and support delete annotation via CLI #4940

Merged
merged 3 commits into from
Aug 24, 2020
Merged

Do not delete previous annotation and support delete annotation via CLI #4940

merged 3 commits into from
Aug 24, 2020

Commits on Aug 19, 2020

  1. Do not delete previous annotation 

    Currently, if passing another annotations, original previous annotation
will be removed and the passed new annotations will be added.

It may give users some confused that why my previous annotation gone.
So it is better to not delete user's previous annotation when adding new
annotation, but at the same time, need to provide a feature that
support to delete annotation by user via ClI, e.g.
wsk action update hello --del-annotation key1 --del-annotation key2

CLI side needs to support as well
    @ningyougang
    ningyougang committed Aug 19, 2020
    Configuration menu
    Copy the full SHA
    188944c View commit details
    Browse the repository at this point in the history

  2. Add test cases

    @ningyougang
    ningyougang committed Aug 19, 2020
    Configuration menu
    Copy the full SHA
    b14628c View commit details
    Browse the repository at this point in the history

  3. Fix some review comments

    @ningyougang
    ningyougang committed Aug 19, 2020
    Configuration menu
    Copy the full SHA
    3557896 View commit details
    Browse the repository at this point in the history