Add dotnet core 3.1 action support #1098
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I think this is the only thing to be added for dotnet core 3.1 support right?
rabbah
approved these changes
Aug 13, 2020
|
@woutersterp Please rebase and add some "helloworld" style unit and integration tests (manifests) to verify support in our CI/CD process (Travis). Please reference the work done for the updated Rust runtime in this PR to get an idea of what the balance of work is needed here: #1119 |
mrutkows
requested changes
Mar 2, 2021
| @@ -480,6 +480,21 @@ var RUNTIME_DETAILS = []byte(`{ | |||
| "attachmentName": "codefile", | |||
| "attachmentType": "text/plain" | |||
| } | |||
| }, | |||
| { | |||
| "kind": "dotnet:3.1", | |||
There was a problem hiding this comment.
Please add unit tests and perhaps an integration test to validate support in our CI/CD process. Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this is the only thing to be added for dotnet core 3.1 support right?