Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support alt namespace uuid as tenant id on swagger api creates/deletes #1091

Merged
merged 2 commits into from
Mar 20, 2020

Conversation

pwplusnick
Copy link
Contributor

No description provided.

Copy link
Contributor

@mrutkows mrutkows left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -1014,9 +1014,9 @@ func (deployer *ServiceDeployer) createAction(pkgname string, action *whisk.Acti

func (deployer *ServiceDeployer) getAnnotationsFromPackageActionOrSequence(packageActionName string) *whisk.KeyValueArr {

if len(packageActionName)!=0 {
if len(packageActionName) != 0 {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hehe

apiCreateReqOptions.AccessToken = deployer.Client.Config.ApigwAccessToken
// In the case of IAM namespaces, we must use the ApigwTenantId as the SpaceGuid
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Applying the same IAM token (securekey) logic here as we have added elsewhere... LGTM

@mrutkows mrutkows merged commit 20d66fa into apache:master Mar 20, 2020
@mrutkows mrutkows self-assigned this Mar 20, 2020
@mrutkows mrutkows added the bug label Mar 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants