Added date and commit SHA to the version command #1047
Conversation
AnthonyAmanse
force-pushed
the
dev-build
branch
4 times, most recently
from
0df99ea
to
6ed605e
Compare
AnthonyAmanse
changed the title
This commit adds in a date and the head commit SHA. This makes it easy for end-users to verify if their binary is indeed the latest one. The date and git commit are also added in builds for release candidates. Example: ``` ./wskdeploy version wskdeploy version: latest wskdeploy git commit: 50aacbc wskdeploy build date: 2019-03-28T20:41:05Z ``` Signed-off-by: AnthonyAmanse <[email protected]>
AnthonyAmanse
force-pushed
the
dev-build
branch
from
6ed605e
to
8582b9d
Compare
There was a problem hiding this comment.
This is a welcome addition for developers that need this level of granularity; my only hesitation would be that Apache release process is quite ground in strict guidelines around versioning and do not want to promote use of daily/interim/developer builds. Wondering if we could gate display on the appearance of the Verbose flag in conjunction with the Version command? Would like a 2nd opinion before approving.
|
@pritidesai @jthomas any thoughts on my comments above before approval? |
|
yup I agree with @mrutkows, I like the date but commit hash is too granular, how does this impact on the released binaries? @houshengbo please weigh in your comments here. |
|
@pritidesai @houshengbo Perhaps the most reasonable plan is to merge this and if anyone complains we can redact the display OR add extra logic to display on when --verbose is also provided. What do you think? |
|
This PR looks good to me. Adding git commit hash and the date makes it more self-elaborated for a build. |
This commit adds in a date and the head commit SHA. This makes it easy
for end-users to verify if their binary is indeed the latest one. The
date and git commit are also added in builds for release candidates.
Example:
Fixes: #1000
Signed-off-by: AnthonyAmanse [email protected]