-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the base source code for Ruby 2.5 Runtime #1
Conversation
…lledMoreThanOnce work
README.md
Outdated
--> | ||
|
||
# Apache OpenWhisk runtimes for Ruby | ||
[![Build Status](https://travis-ci.org/remore/openwhisk-runtime-ruby.svg?branch=master)](https://travis-ci.org/remore/openwhisk-runtime-ruby) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
update this link.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated with 73c0cb7
|
||
Or you can use `wskdev` and create a soft link to the target ansible environment, for example: | ||
``` | ||
ln -s ${ROOTDIR}/ansible/environments/local ${OPENWHISK_HOME}/ansible/environments/local-ruby |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
once the manifest change is made upstream i dont think you need this special environment here and we can simplify here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Noted. Which one is corresponding PR for this?
README.md
Outdated
Or save in your `$HOME/.gradle/gradle.properties` | ||
``` | ||
systemProp.http.proxyHost=localhost | ||
systemProp.http.proxyPort=3128 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hmm why did you need to use a proxy? this isn't generally needed even for mac anymore.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah those are just coming from other runtime documentation such as nodejs or php. Maybe better to remove these proxy-related documentations unless I have examined it's working?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn’t be needed here or in other runtimes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
override val testLargeInput = { | ||
TestConfig(""" | ||
|def main(args) | ||
| puts 'hello stdout' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
dont think test cares about stdout/stderr here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are right. Fixed this with 73c0cb7
@@ -0,0 +1,5 @@ | |||
<?xml version="1.0" encoding="UTF-8" standalone="no"?> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
dont need this file.
Related Issue(s):
apache/openwhisk#3725
https://github.com/remore/openwhisk-runtime-ruby/issues?q=is%3Aissue+is%3Aclosed