chore: fix spelling #219
Merged
chore: fix spelling #219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rabbah
reviewed
Mar 9, 2021
README.md
Outdated
| @@ -435,7 +435,7 @@ The following optional parameters are supported: | |||
| - `annotations` - object containing annotations for the action (default: `{}`) | |||
| - `limits` - object containing limits for the action (default: `{}`) | |||
| - `kind` - runtime environment parameter, ignored when `action` is an object (default: `nodejs:default`) | |||
| - `version` - set semantic version of the action. If parameter is empty when create new action openwisk generate 0.0.1 value when update an action increase the patch version. | |||
| - `version` - set semantic version of the action. If parameter is empty when create new action openwhisk generate 0.0.1 value when update an action increase the patch version. | |||
There was a problem hiding this comment.
Grammar needs more fixing here and casing for ow should be OpenWhisk.
Separately we should remove the reference to version. It is incorrect entirely.
rabbah
approved these changes
Mar 9, 2021
|
If you merge one in, I will come back stronger with 2 !! or 2 dozen 😅 Thanks for all the PRs @jbampton. |
|
Thanks for merging them all in @rabbah 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.