-
Notifications
You must be signed in to change notification settings - Fork 515
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(services/s3): add append support #5428
base: main
Are you sure you want to change the base?
Conversation
core/src/services/s3/backend.rs
Outdated
// Only S3 Express One Zone storage class supports append. | ||
write_can_append: self | ||
.core | ||
.default_storage_class |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, checking with default_storage_class
doesn't seem like a good idea to me. How about adding a new flag called enable_write_with_append
? Users who confirm that they support append
can enable this.
req = req.header(format!("{X_AMZ_META_PREFIX}{key}"), value) | ||
} | ||
} | ||
req = self.insert_metadata_headers(req, Some(size), args); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, I assume that only the first append call supports setting up metadata. We don't need to repeat the metadata for subsequent append requests.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Which issue does this PR close?
Close: #5351
Are there any user-facing changes?
when writing to S3 Express One Zone, user can: