Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(core): Add content_encoding to MetaData #5400

Merged
merged 3 commits into from
Dec 8, 2024
Merged

feat(core): Add content_encoding to MetaData #5400

merged 3 commits into from
Dec 8, 2024

Conversation

Frank-III
Copy link
Contributor

Which issue does this PR close?

follow #5390,

I think we need to add content_encoding to the metadata to properly test it? docs.aws.amazon.com/AmazonS3/latest/API/API_HeadObject.html#API_HeadObject_ResponseSyntax

Are there any user-facing changes?

MetaData now includes a field content_encoding

@Frank-III Frank-III requested a review from Xuanwo as a code owner December 6, 2024 14:46
@Frank-III Frank-III changed the title Add content encoding metadata feat(core): Add content_encoding to MetaData Dec 6, 2024
Xuanwo
Xuanwo approved these changes Dec 8, 2024
View reviewed changes
Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @Frank-III for working on this!

@Xuanwo Xuanwo merged commit 7cde1f5 into apache:main Dec 8, 2024
240 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Xuanwo Xuanwo Xuanwo approved these changes

Assignees
No one assigned
Labels
releases-note/feat
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Frank-III @Xuanwo