Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: fix cargo clippy #5384

Merged
merged 1 commit into from
Dec 3, 2024
Merged

chore: fix cargo clippy #5384

merged 1 commit into from
Dec 3, 2024

Conversation

meteorgan
Copy link
Contributor

Which issue does this PR close?

none

Rationale for this change

following: #5379

What changes are included in this PR?

Are there any user-facing changes?

@meteorgan meteorgan requested a review from Xuanwo as a code owner December 3, 2024 04:52
@meteorgan
Copy link
Contributor Author

meteorgan commented Dec 3, 2024 •
edited
Loading

The configuration in hdfs_default_on_minio_s3 and hdfs_default_on_azurite_azblob are a bit complicated. I didn't address them in #5353. but they remain troublesome.

Xuanwo
Xuanwo approved these changes Dec 3, 2024
View reviewed changes
Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @meteorgan for helping fix this!

@Xuanwo Xuanwo merged commit d9807d1 into apache:main Dec 3, 2024
237 of 239 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Xuanwo Xuanwo Xuanwo approved these changes

Assignees
No one assigned
Labels
releases-note/chore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@meteorgan @Xuanwo